Does not update outdated models

#10
by ejschwartz - opened

Hi,

I noticed that this bot doesn't submit PRs when a model is updated if it already has a safetensors model. So potentially this would allow the safetensors model to become out of sync with the updated model.

Ed

Safetensors org

cc @Narsil fyi

Safetensors org

Ty for the ping.

Not sure I have a great method to fix that though.

When multiple model files are in a repo, there's no clear way to know who's what or where things come from.
The current script checks for the file exist, and assumes the files are OK if not present.

We could add a *force option in the space. Would that be enough ?

Maybe you could add some metadata to the safetensors model that contains the hash of the original model or the commit it came from?

I don't think a force option would be very helpful since most people will probably interact via the automated PR. The main problem is that I assumed the bot would take care of updating the safetensors models for me. Most people will probably not even look at this space. I only looked once I thought it was strange that there were no PRs after I changed the original model.

I was able to work around the problem by deleting the safetensors file, and then I got a new PR. This is pretty intuitive, if you realize that the safetensors model has become out of date.

Sign up or log in to comment