Update app.py

app.py

@@ -33,7 +33,8 @@ class QuizGenerator:
                 messages=[
                     {
                         "role": "system",
-                        "content": "You are a quiz generator. Create clear questions with concise answer options."
+                        "content": """You are a quiz generator. Create clear questions with concise answer options.
+                        Always return valid JSON array of questions. Format answers as short, clear phrases."""
                     },
                     {
                         "role": "user",
@@ -41,7 +42,7 @@ class QuizGenerator:
                     }
                 ],
                 model="llama-3.2-3b-preview",
-                temperature=0.2,
+                temperature=0,
                 max_tokens=2048
             )
             
@@ -49,68 +50,105 @@ class QuizGenerator:
             return self._validate_questions(questions, num_questions)
             
         except Exception as e:
+            print(f"Error in generate_questions: {str(e)}")
+            print(f"Response content: {response.choices[0].message.content if response else 'No response'}")
             raise QuizGenerationError(f"Failed to generate questions: {str(e)}")
     
     def _create_prompt(self, text: str, num_questions: int) -> str:
-        return f"""Create exactly {num_questions} multiple choice questions based on this text:
-        {text}
-        
-        For each question:
-        1. Create a clear, concise question
-        2. Provide exactly 4 options
-        3. Mark the correct answer with the index (0-3)
-        4. Ensure options are concise and clear
-        
-        Return ONLY a JSON array with this EXACT format - no other text:
-        [
-            {{
-                "question": "Question text here?",
-                "options": [
-                    "Brief option 1",
-                    "Brief option 2",
-                    "Brief option 3",
-                    "Brief option 4"
-                ],
-                "correct_answer": 0
-            }}
-        ]
-        Keep all options concise (10 words or less each).
-        """
+        return f"""Generate exactly {num_questions} multiple choice questions based on the following text. Follow these rules strictly:
+
+1. Each question must be clear and focused
+2. Provide exactly 4 options for each question
+3. Mark the correct answer with index (0-3)
+4. Keep all options concise (under 10 words)
+5. Return ONLY a JSON array with this exact format:
+[
+    {{
+        "question": "Clear question text here?",
+        "options": [
+            "Brief option 1",
+            "Brief option 2",
+            "Brief option 3",
+            "Brief option 4"
+        ],
+        "correct_answer": 0
+    }}
+]
+
+Text to generate questions from:
+{text}
+
+Important: Return only the JSON array, no other text or formatting."""
     
     def _parse_response(self, response_text: str) -> List[Dict]:
-        response_text = response_text.replace("```json", "").replace("```", "").strip()
-        start_idx = response_text.find("[")
-        end_idx = response_text.rfind("]")
-        
-        if start_idx == -1 or end_idx == -1:
-            raise ValueError("No valid JSON array found in response")
+        """Parse response with improved error handling"""
+        try:
+            # Clean up the response text
+            cleaned_text = response_text.strip()
+            cleaned_text = cleaned_text.replace('```json', '').replace('```', '').strip()
+            
+            # Find the JSON array
+            start_idx = cleaned_text.find('[')
+            end_idx = cleaned_text.rfind(']')
+            
+            if start_idx == -1 or end_idx == -1:
+                raise ValueError("No valid JSON array found in response")
+            
+            json_text = cleaned_text[start_idx:end_idx + 1]
             
-        response_text = response_text[start_idx:end_idx + 1]
-        return json.loads(response_text)
+            # Attempt to parse the JSON
+            try:
+                return json.loads(json_text)
+            except json.JSONDecodeError as e:
+                print(f"JSON Parse Error: {str(e)}")
+                print(f"Attempted to parse: {json_text}")
+                raise
+                
+        except Exception as e:
+            print(f"Error parsing response: {str(e)}")
+            print(f"Original response: {response_text}")
+            raise ValueError(f"Failed to parse response: {str(e)}")
     
     def _validate_questions(self, questions: List[Dict], num_questions: int) -> List[Question]:
+        """Validate questions with improved error checking"""
         validated = []
+        
         for q in questions:
-            if not self._is_valid_question(q):
+            try:
+                if not self._is_valid_question(q):
+                    print(f"Invalid question format: {q}")
+                    continue
+                    
+                validated.append(Question(
+                    question=q["question"].strip(),
+                    options=[str(opt).strip()[:100] for opt in q["options"]],
+                    correct_answer=int(q["correct_answer"]) % 4
+                ))
+            except Exception as e:
+                print(f"Error validating question: {str(e)}")
                 continue
-            validated.append(Question(
-                question=q["question"].strip(),
-                options=[opt.strip()[:100] for opt in q["options"]],
-                correct_answer=int(q["correct_answer"]) % 4
-            ))
         
         if not validated:
             raise ValueError("No valid questions after validation")
-            
+        
         return validated[:num_questions]
     
     def _is_valid_question(self, question: Dict) -> bool:
-        return (
-            all(key in question for key in ["question", "options", "correct_answer"]) and
-            isinstance(question["options"], list) and
-            len(question["options"]) == 4 and
-            all(isinstance(opt, str) for opt in question["options"])
-        )
+        """Check if question format is valid"""
+        try:
+            return (
+                isinstance(question, dict) and
+                all(key in question for key in ["question", "options", "correct_answer"]) and
+                isinstance(question["question"], str) and
+                isinstance(question["options"], list) and
+                len(question["options"]) == 4 and
+                all(isinstance(opt, str) for opt in question["options"]) and
+                isinstance(question["correct_answer"], (int, str)) and
+                int(question["correct_answer"]) in range(4)
+            )
+        except Exception as e:
+            print(f"Question validation error: {str(e)}")
+            return False
 
 class FontManager:
     """Manages font installation and loading for the certificate generator"""
@@ -558,7 +596,7 @@ def create_quiz_interface():
         # State management
         current_questions = gr.State([])
         current_question_idx = gr.State(0)
-        answer_state = gr.State([None] * 5)  # Store all answers
+        answer_state = gr.State([None] * 5)
         
         # Header
         gr.Markdown("""
@@ -568,7 +606,7 @@ def create_quiz_interface():
         
         with gr.Tabs() as tabs:
             # Profile Setup Tab
-            with gr.Tab(id=1,label="📋 Step 1: Profile Setup"):
+            with gr.Tab(id=1, label="📋 Step 1: Profile Setup"):
                 with gr.Row():
                     name = gr.Textbox(label="Full Name", placeholder="Enter your full name")
                     email = gr.Textbox(label="Email", placeholder="Enter your email")
@@ -594,21 +632,17 @@ def create_quiz_interface():
                 generate_btn = gr.Button("Generate Assessment", variant="primary", size="lg")
             
             # Assessment Tab
-            with gr.Tab(id=2,label="📝 Step 2: Take Assessment") as assessment_tab:
-                with gr.Column(visible=True) as question_box:
-                    # Question section
-                    with gr.Group():
-                        # Question display
-                        question_display = gr.Markdown("", label="Current Question")
-                        
-                        # Single radio group for current question
+            with gr.Tab(id=2, label="📝 Step 2: Take Assessment"):
+                with gr.Column() as main_container:
+                    # Questions Section
+                    with gr.Column(visible=True) as question_box:
+                        question_display = gr.Markdown("")
                         current_options = gr.Radio(
                             choices=[],
                             label="Select your answer:",
                             visible=False
                         )
                         
-                        # Navigation
                         with gr.Row():
                             prev_btn = gr.Button("← Previous", variant="secondary", size="sm")
                             question_counter = gr.Markdown("Question 1")
@@ -616,125 +650,135 @@ def create_quiz_interface():
                         
                         gr.Markdown("---")  # Separator
                         
-                        with gr.Row():
-                            submit_btn = gr.Button(
-                                "Submit Assessment",
-                                variant="primary",
-                                size="lg"
-                            )
+                        submit_btn = gr.Button(
+                            "Submit Assessment",
+                            variant="primary",
+                            size="lg"
+                        )
+
+                    # Results Section in Assessment Tab
+                    with gr.Column(visible=False) as results_group:
+                        result_message = gr.Markdown(
+                            label="Result",
+                            show_label=True
+                        )
+                        feedback_box = gr.Markdown(
+                            label="Detailed Feedback",
+                            show_label=True
+                        )
+                        gr.Markdown("---")  # Separator
+                        with gr.Row(equal_height=True):
                             reset_btn = gr.Button(
                                 "Reset Quiz",
                                 variant="secondary",
-                                size="lg"
+                                size="lg",
+                                visible=False
                             )
-                
-            # Results section
-            with gr.Group(visible=False) as results_group:
-                feedback_box = gr.Markdown("")
-                with gr.Row():
-                    view_cert_btn = gr.Button(
-                        "View Certificate",
-                        variant="primary",
-                        size="lg",
-                        visible=False
-                    )
-                    back_to_assessment = gr.Button(  # Add this button definition
-                        "Back to Assessment",
-                        variant="secondary",
-                        size="lg",
-                        visible=True
-                    )
-            
-            # Certification Tab
-            with gr.Tab(id=3,label="🎓 Step 3: Get Certified"):
-                score_display = gr.Number(label="Your Score")
-                result_message = gr.Markdown("")
+                            view_cert_btn = gr.Button(
+                                "View Certificate",
+                                variant="primary",
+                                size="lg",
+                                visible=False
+                            )                    
+
+            # Certification Tab (Hidden by default)
+            with gr.Tab(id=3, label="🎓 Step 3: Get Certified", visible=False) as cert_tab:
+                score_display = gr.Number(label="Your Score", visible=False)
                 course_name = gr.Textbox(
                     label="Certification Title",
-                    value="Professional Assessment Certification"
+                    value="Professional Assessment Certification",
+                    interactive=False  # Make it non-editable
                 )
                 certificate_display = gr.Image(label="Your Certificate")
 
+        # Update view_cert_btn click handler to show certification tab
+        def show_certificate_tab():
+            return [
+                gr.update(visible=True),  # Make cert_tab visible
+                gr.update(selected=3)     # Switch to cert_tab
+            ]
+
+
         # Helper Functions
         def on_generate_questions(text, num_questions):
-            """Generate quiz questions and setup initial state"""
+            if not text.strip():
+                return [
+                    "",
+                    gr.update(visible=False),
+                    gr.update(choices=[], visible=False),
+                    "",
+                    [],
+                    0,
+                    [None] * 5,
+                    gr.update(selected=1),
+                    gr.update(visible=False),
+                    gr.update(visible=False)
+                ]
+            
             success, questions = quiz_app.generate_questions(text, num_questions)
-            if not success:
+            if not success or not questions:
                 return [
-                    "",                                     # question_display
-                    gr.update(choices=[], visible=False),   # current_options
-                    "",                                     # question_counter
-                    gr.update(visible=False),               # question_box
-                    [],                                     # current_questions
-                    0,                                      # current_question_idx
-                    [None] * 5,                            # answer_state
-                    gr.Tabs(selected=2),                    # tabs
-                    gr.update(visible=False),               # results_group
-                    gr.update(visible=False)                # view_cert_btn - added this
+                    "",
+                    gr.update(visible=False),
+                    gr.update(choices=[], visible=False),
+                    "",
+                    [],
+                    0,
+                    [None] * 5,
+                    gr.update(selected=1),
+                    gr.update(visible=False),
+                    gr.update(visible=False)
                 ]
             
-            # Setup initial state with first question
-            initial_answers = [None] * len(questions)
             question = questions[0]
-            question_html = f"""## Question 1
-        {question.question}
-        
-        Please select one answer:"""
+            question_md = f"""### Question 1
+{question.question}"""
             
             return [
-                question_html,                              # question_display
+                question_md,
+                gr.update(visible=True),
                 gr.update(
                     choices=question.options,
                     value=None,
                     visible=True,
-                    label="Select your answer for Question 1:"
-                ),                                         # current_options
-                f"Question 1 of {len(questions)}",         # question_counter
-                gr.update(visible=True),                   # question_box
-                questions,                                 # current_questions
-                0,                                        # current_question_idx
-                initial_answers,                          # answer_state
-                gr.Tabs(selected=2),                      # tabs
-                gr.update(visible=False),                 # results_group
-                gr.update(visible=False)                  # view_cert_btn - added this
+                    label="Select your answer:"
+                ),
+                f"Question 1 of {len(questions)}",
+                questions,
+                0,
+                [None] * len(questions),
+                gr.update(selected=2),
+                gr.update(visible=False),
+                gr.update(visible=False)
             ]
+
         def navigate(direction, current_idx, questions, answers, current_answer):
-            """Handle navigation between questions"""
             if not questions:
-                return [
-                    0,
-                    answers,
-                    "",
-                    gr.update(choices=[], value=None, visible=False),
-                    "",
-                    gr.update(visible=False)
-                ]
+                return [0, answers, "", gr.update(choices=[], visible=False), "", gr.update(visible=False)]
             
             new_answers = list(answers)
-            if current_answer and 0 <= current_idx < len(new_answers):
+            if current_answer is not None and 0 <= current_idx < len(new_answers):
                 new_answers[current_idx] = current_answer
             
             new_idx = max(0, min(len(questions) - 1, current_idx + direction))
             question = questions[new_idx]
             
+            question_md = f"""### Question {new_idx + 1}
+{question.question}"""
+            
             return [
                 new_idx,
                 new_answers,
-                f"## Question {new_idx + 1}\n{question.question}\n\nPlease select one answer:",
+                question_md,
                 gr.update(
                     choices=question.options,
                     value=new_answers[new_idx] if new_idx < len(new_answers) else None,
                     visible=True,
-                    label=f"Select your answer for Question {new_idx + 1}:"
+                    label="Select your answer:"
                 ),
                 f"Question {new_idx + 1} of {len(questions)}",
                 gr.update(visible=True)
-            ]  
-        def handle_prev(current_idx, questions, answers, current_answer):
-            return navigate(-1, current_idx, questions, answers, current_answer)
-
-        def handle_next(current_idx, questions, answers, current_answer):
-            return navigate(1, current_idx, questions, answers, current_answer)
+            ]
 
         def update_answer_state(answer, idx, current_answers):
             new_answers = list(current_answers)
@@ -748,9 +792,16 @@ def create_quiz_interface():
 
         def view_certificate():
             """Navigate to certificate tab"""
-            return gr.Tabs(selected=2)
+            return gr.update(selected=3)
+
+        def handle_prev(current_idx, questions, answers, current_answer):
+                    return navigate(-1, current_idx, questions, answers, current_answer)
+            
+        def handle_next(current_idx, questions, answers, current_answer):
+            return navigate(1, current_idx, questions, answers, current_answer)
         
         def on_submit(questions, answers, current_idx, current_answer):
+            """Handle quiz submission with proper Markdown rendering and emojis"""
             final_answers = list(answers)
             if 0 <= current_idx < len(final_answers):
                 final_answers[current_idx] = current_answer
@@ -762,71 +813,140 @@ def create_quiz_interface():
                     0,
                     "",
                     gr.update(visible=True),
-                    gr.Tabs(selected=2),
+                    gr.update(visible=True),
+                    gr.update(visible=False),
                     gr.update(visible=False)
                 ]
             
             score, passed, feedback = quiz_app.calculate_score(final_answers[:len(questions)])
             
-            feedback_html = "# Assessment Results\n\n"
+            # Create feedback content using proper Markdown with emojis
+            feedback_content = f"""# Assessment Results
+        
+        **Score: {score:.1f}%**
+        
+        """
+            
             for i, (q, f) in enumerate(zip(questions, feedback)):
+                icon = "✅" if f.is_correct else "❌"
                 color = "green" if f.is_correct else "red"
-                symbol = "✅" if f.is_correct else "❌"
                 
-                feedback_html += f"""### Question {i+1}
+                # Using markdown syntax with color formatting
+                feedback_content += f"""### Question {i+1}
         {q.question}
-        <div style="color: {color}; padding: 10px; margin: 10px 0; border-left: 3px solid {color}; background-color: {'#f8fff8' if f.is_correct else '#fff8f8'};">
-            {symbol} Your answer: {f.selected or "No answer"}
-            {'' if f.is_correct else f'<br>Correct answer: {f.correct_answer}'}
-        </div>\n"""
-            
-            result_msg = "🎉 Passed!" if passed else "Please try again"
-            if not passed:
-                feedback_html += f"""<div style="background-color: #ffe6e6; padding: 20px; margin: 20px 0; border-radius: 10px; border: 1px solid #ffcccc;">
-            <h3 style="color: #cc0000; margin-top: 0;">Please Try Again</h3>
-            <p style="margin: 10px 0;">Your score: {score:.1f}%</p>
-            <p style="margin: 10px 0;">You need 80% or higher to pass and receive a certificate.</p>
-        </div>"""
+        
+        {icon} **Your answer:** {f.selected or 'No answer'}
+        {'' if f.is_correct else f'**Correct answer:** {f.correct_answer}'}
+        
+        """
+            
+            # Add summary box
+            if passed:
+                feedback_content += f"""
+        ---
+        ## 🎉 Congratulations!
+        You passed with a score of {score:.1f}%!
+        """
             else:
-                feedback_html += f"""<div style="background-color: #e6ffe6; padding: 20px; margin: 20px 0; border-radius: 10px; border: 1px solid #ccffcc;">
-            <h3 style="color: #008000; margin-top: 0;">🎉 Congratulations!</h3>
-            <p style="margin: 10px 0;">You passed with a score of {score:.1f}%</p>
-            <p style="margin: 10px 0;">Click "View Certificate" to see your certificate.</p>
-        </div>"""
+                feedback_content += f"""
+        ---
+        ## Need Improvement
+        You scored {score:.1f}%. You need 80% or higher to pass.
+        Please try again.
+        """
             
             return [
-                feedback_html,
-                gr.update(visible=True),
-                score,
-                result_msg,
-                gr.update(visible=False),
-                gr.Tabs(selected=2),
-                gr.update(visible=passed)
+                feedback_content,                # feedback_box
+                gr.update(visible=True),         # results_group
+                score,                           # score_display
+                f"Score: {score:.1f}%",         # result_message
+                gr.update(visible=False),        # question_box
+                gr.update(visible=not passed),   # reset_btn
+                gr.update(visible=passed),       # view_cert_btn
+                gr.update(selected=2)            # tabs
             ]
-        # Event handlers
-       
-        generate_btn.click(fn=on_generate_questions, inputs=[text_input, num_questions], outputs=[question_display, current_options, question_counter, question_box, current_questions, current_question_idx, answer_state, tabs, results_group, view_cert_btn]).then(fn=lambda: gr.Tabs(selected=2), outputs=tabs)
+            
+        # Event Handlers
+        generate_btn.click(
+            fn=on_generate_questions,
+            inputs=[text_input, num_questions],
+            outputs=[
+                question_display,
+                question_box,
+                current_options,
+                question_counter,
+                current_questions,
+                current_question_idx,
+                answer_state,
+                tabs,
+                results_group,
+                view_cert_btn
+            ]
+        )
         
-        prev_btn.click(fn=handle_prev, inputs=[current_question_idx, current_questions, answer_state, current_options], outputs=[current_question_idx, answer_state, question_display, current_options, question_counter, question_box])
+        prev_btn.click(
+            fn=handle_prev,
+            inputs=[current_question_idx, current_questions, answer_state, current_options],
+            outputs=[current_question_idx, answer_state, question_display, current_options, question_counter, question_box]
+        )
         
-        next_btn.click(fn=handle_next, inputs=[current_question_idx, current_questions, answer_state, current_options], outputs=[current_question_idx, answer_state, question_display, current_options, question_counter, question_box])
+        next_btn.click(
+            fn=handle_next,
+            inputs=[current_question_idx, current_questions, answer_state, current_options],
+            outputs=[current_question_idx, answer_state, question_display, current_options, question_counter, question_box]
+        )
         
-        current_options.change(fn=update_answer_state, inputs=[current_options, current_question_idx, answer_state], outputs=answer_state)
+        submit_btn.click(
+            fn=on_submit,
+            inputs=[current_questions, answer_state, current_question_idx, current_options],
+            outputs=[
+                feedback_box,
+                results_group,
+                score_display,
+                result_message,  # Now properly defined
+                question_box,
+                reset_btn,
+                view_cert_btn,
+                tabs
+            ]
+        )
         
-        submit_btn.click(fn=on_submit, inputs=[current_questions, answer_state, current_question_idx, current_options], outputs=[feedback_box, results_group, score_display, result_message, question_box, tabs, view_cert_btn])
-
-        reset_btn.click(fn=reset_quiz, inputs=[text_input, num_questions], outputs=[question_display, current_options, question_counter, question_box, current_questions, current_question_idx, answer_state, tabs, results_group, view_cert_btn])
+        reset_btn.click(
+            fn=on_generate_questions,
+            inputs=[text_input, num_questions],
+            outputs=[
+                question_display,
+                question_box,
+                current_options,
+                question_counter,
+                current_questions,
+                current_question_idx,
+                answer_state,
+                tabs,
+                results_group,
+                view_cert_btn
+            ]
+        )
         
-        view_cert_btn.click(fn=lambda: gr.Tabs(selected=3), outputs=tabs)
+        view_cert_btn.click(
+            fn=show_certificate_tab,
+            outputs=[cert_tab, tabs]
+        )
         
-        back_to_assessment.click(fn=lambda: gr.Tabs(selected=2), outputs=tabs)
+        current_options.change(
+            fn=update_answer_state,
+            inputs=[current_options, current_question_idx, answer_state],
+            outputs=answer_state
+        )
+        
+        score_display.change(
+            fn=lambda s, n, c, l, p: quiz_app.certificate_generator.generate(s, n, c, l, p) or gr.update(value=None),
+            inputs=[score_display, name, course_name, company_logo, participant_photo],
+            outputs=certificate_display
+        )
         
-        score_display.change(fn=lambda s, n, c, l, p: quiz_app.certificate_generator.generate(s, n, c, l, p) or gr.update(value=None), inputs=[score_display, name, course_name, company_logo, participant_photo], outputs=certificate_display)
-
-
     return demo
 
 if __name__ == "__main__":
     demo = create_quiz_interface()
-    demo.launch() 
-            
+    demo.launch()